linux-kernel - Re: [PATCH v4 5/6] x86/CPU/AMD: Prefix messages with x86/amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260121104920.GAaXCvMIrq8cQ1MPDP@fat_crate.local>
Date: Wed, 21 Jan 2026 11:49:20 +0100
From: Borislav Petkov <bp@...en8.de>
To: "Mario Limonciello (AMD)" <superm1@...nel.org>
Cc: Yazen Ghannam <yazen.ghannam@....com>, Jean Delvare <jdelvare@...e.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/6] x86/CPU/AMD: Prefix messages with x86/amd

On Wed, Jan 21, 2026 at 12:04:30AM -0600, Mario Limonciello (AMD) wrote:
> To clarify which messages come from arch/x86/kernel/cpu/amd.c add
> a prefix to all messages instead of just the previous reset reason.
> 
> Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>
> Signed-off-by: Mario Limonciello (AMD) <superm1@...nel.org>
> ---
> v3:
>  * add tag, put in it's own series
> ---
>  arch/x86/kernel/cpu/amd.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index bc94ff1e250ad..c19c4ee74dd1f 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -1,4 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0-only
> +#define pr_fmt(fmt) "x86/amd: " fmt

I'm still not sure about this. There are a lot of places which you can call
"x86/amd:" - not only this one. So if anything, this prefix should be called
"x86/CPU:".

But looking at cpu/intel.c, they have "x86/tme:" and "x86/mktme:" prefixes
there for the TME specific stuff.

So I still don't see a clear working logic to apply to x86/cpu/ compilation
units.

So unless there's a better idea, pls drop this for now.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette