linux-kernel - Re: [PATCH 1/2] PCI: dwc: ep: Fix resizable BAR support for multi-PF configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d22c37a1-0b75-4f8b-a846-f20bc9a9cca7@ti.com>
Date: Wed, 21 Jan 2026 17:10:55 +0530
From: Aksh Garg <a-garg7@...com>
To: Niklas Cassel <cassel@...nel.org>
CC: <linux-pci@...r.kernel.org>, <jingoohan1@...il.com>, <mani@...nel.org>,
	<lpieralisi@...nel.org>, <kwilczynski@...nel.org>, <robh@...nel.org>,
	<bhelgaas@...gle.com>, <linux-kernel@...r.kernel.org>, <s-vadapalli@...com>,
	<danishanwar@...com>
Subject: Re: [PATCH 1/2] PCI: dwc: ep: Fix resizable BAR support for multi-PF
 configurations



> On Wed, Jan 21, 2026 at 11:12:13AM +0530, Aksh Garg wrote:
>> +static void dw_pcie_ep_init_non_sticky_registers(struct dw_pcie *pci)
>> +{
>> +	struct dw_pcie_ep *ep = &pci->ep;
>> +	u8 func_no, funcs;
>> +
>> +	funcs = ep->epc->max_functions;
> 
> Initialize this on the same line as the variable is declared.
> u8 func_no; will be on a separate line.
> 

I will fix this nit.

> 
>> +
>> +	dw_pcie_dbi_ro_wr_en(pci);
>> +
>> +	for (func_no = 0; func_no < funcs; func_no++)
>> +		__dw_pcie_ep_init_non_sticky_registers(ep, func_no);
>>  
>>  	dw_pcie_setup(pci);
>>  	dw_pcie_dbi_ro_wr_dis(pci);
>> -- 
>> 2.34.1
>> 
> 
> 
> Thank you for fixing this!
> 
> Reviewed-by: Niklas Cassel <cassel@...nel.org>
> 
> 
> You do need another patch in this series though, that fixes:
> https://github.com/torvalds/linux/blob/v6.19-rc6/drivers/pci/controller/dwc/pcie-designware-ep.c#L972-L986
> 
> As currently, ptm_cap_base is fetched using dw_pcie_find_ext_capability()
> instead of your new dw_pcie_ep_find_ext_capability() which takes a func_no.
> 

Thank you for pointing this out. I will add a patch for this fix as well.

> 
> Kind regards,
> Niklas
>