linux-kernel - Re: request_irq() usage in wm8350_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90b80379-6799-4600-886d-08ef48d9a35f@opensource.cirrus.com>
Date: Wed, 21 Jan 2026 11:53:28 +0000
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        Lee Jones <lee@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: request_irq() usage in wm8350_register_irq().

On 21/01/2026 11:36 am, Sebastian Andrzej Siewior wrote:
> On 2026-01-21 11:22:32 [+0000], Richard Fitzgerald wrote:
>> Or because request_threaded_irq() supplies a default handler, so
>> handler!=NULL when it calls __setup_irq().
>>
>>
>> int request_threaded_irq(unsigned int irq, irq_handler_t handler,
>> 			 irq_handler_t thread_fn, unsigned long irqflags,
>> 			 const char *devname, void *dev_id)
>> {
>>
>> ...
>>
>> 	if (!handler) {
>> 		if (!thread_fn)
>> 			return -EINVAL;
>> 		handler = irq_default_primary_handler;
>> 	}
>>
>> ...
>>
>>
>> 	retval = __setup_irq(irq, desc, action);
>>
>> ...
>> }
> 
> ->
> 
> |         } else if (new->handler == irq_default_primary_handler &&
> |                    !(desc->irq_data.chip->flags & IRQCHIP_ONESHOT_SAFE)) {
> …
> |                 pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
> |                        new->name, irq);
> |                 ret = -EINVAL;
> 
> Sebastian

Ah. I didn't notice that. Confusing error message. It says
"handler=NULL" but handler != NULL. More like "handler=default".