linux-kernel - Re: [PATCH] mmc: mmci: Fix device_node reference leak in of_get_dml_pipe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpJuUL-GfpYDUNK_e0r-CS=oX-tPXozOtvVmFZ8XLBTTw@mail.gmail.com>
Date: Thu, 22 Jan 2026 19:03:29 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Felix Gu <ustc.gu@...il.com>
Cc: Linus Walleij <linusw@...nel.org>, Srinivas Kandagatla <srini@...nel.org>, 
	Stephen Boyd <sboyd@...eaurora.org>, linux-arm-msm@...r.kernel.org, 
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Felix Gu <gu_0233@...com>
Subject: Re: [PATCH] mmc: mmci: Fix device_node reference leak in of_get_dml_pipe_index()

On Tue, 20 Jan 2026 at 15:26, Felix Gu <ustc.gu@...il.com> wrote:
>
> When calling of_parse_phandle_with_args(), the caller is responsible
> to call of_node_put() to release the reference of device node.
> In of_get_dml_pipe_index(), it does not release the reference.
>
> Fixes: 9cb15142d0e3 ("mmc: mmci: Add qcom dml support to the driver.")
> Signed-off-by: Felix Gu <gu_0233@...com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mmci_qcom_dml.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
> index 3da6112fbe39..67371389cc33 100644
> --- a/drivers/mmc/host/mmci_qcom_dml.c
> +++ b/drivers/mmc/host/mmci_qcom_dml.c
> @@ -109,6 +109,7 @@ static int of_get_dml_pipe_index(struct device_node *np, const char *name)
>                                        &dma_spec))
>                 return -ENODEV;
>
> +       of_node_put(dma_spec.np);
>         if (dma_spec.args_count)
>                 return dma_spec.args[0];
>
>
> ---
> base-commit: 9b7977f9e39b7768c70c2aa497f04e7569fd3e00
> change-id: 20260117-mmci_qcom_dml-e169407da7bf
>
> Best regards,
> --
> Felix Gu <gu_0233@...com>
>