linux-kernel - Re: [PATCH v8 02/10] mfd: nxp-siul2: add support for NXP SIUL2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25fb1bb85424e9d27348a51ce5bb1fe727d363ed.camel@svanheule.net>
Date: Thu, 22 Jan 2026 19:52:57 +0100
From: Sander Vanheule <sander@...nheule.net>
To: Khristine Andreea Barbulescu <khristineandreea.barbulescu@....nxp.com>, 
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,  Krzysztof Kozlowski	
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Chester Lin	
 <chester62515@...il.com>, Matthias Brugger <mbrugger@...e.com>, Ghennadi
 Procopciuc <ghennadi.procopciuc@....com>, Larisa Grigore
 <larisa.grigore@....com>, Lee Jones	 <lee@...nel.org>, Shawn Guo
 <shawnguo@...nel.org>, Sascha Hauer	 <s.hauer@...gutronix.de>, Fabio
 Estevam <festevam@...il.com>, Dong Aisheng	 <aisheng.dong@....com>, Jacky
 Bai <ping.bai@....com>, Greg Kroah-Hartman	 <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Alberto Ruiz <aruizrui@...hat.com>, Christophe Lizzi
 <clizzi@...hat.com>, 	devicetree@...r.kernel.org, Enric Balletbo
 <eballetb@...hat.com>, Eric Chanudet	 <echanude@...hat.com>,
 imx@...ts.linux.dev, 	linux-arm-kernel@...ts.infradead.org,
 linux-gpio@...r.kernel.org, 	linux-kernel@...r.kernel.org, NXP S32 Linux
 Team <s32@....com>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH v8 02/10] mfd: nxp-siul2: add support for NXP SIUL2

Hi Khristine,

On Tue, 2026-01-20 at 13:59 +0200, Khristine Andreea Barbulescu wrote:
> +static const struct regmap_config nxp_siul2_regmap_pgpdo_conf = {
> +	.val_bits = 16,
> +	.val_format_endian = REGMAP_ENDIAN_LITTLE,
> +	.reg_bits = 32,
> +	.reg_stride = 2,
> +	.cache_type = REGCACHE_FLAT,
> +	.use_raw_spinlock = true,
> +};

I see you are using REGCACHE_FLAT ...

> +		if (tmp_conf.cache_type != REGCACHE_NONE)
> +			tmp_conf.num_reg_defaults_raw =
> +				1 + tmp_conf.max_register /
> tmp_conf.reg_stride;

... and initialize the cache defaults from hardware.

This series predates the addition of REGCACHE_FLAT_S in v6.19 with commit
9c7f7262bc1a ("regmap: add flat cache with sparse validity"), but I think
switching to the sparse flat cache would allow you to drop this. Then the cache
will just be initialized on the first hardware access instead of at regmap init.

Best,
Sander