linux-kernel - Re: [PATCH v5 2/7] iio: core: Refactor iio_device_claim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFVGV1BDS81K.3VWJ5CAO37A1X@gmail.com>
Date: Thu, 22 Jan 2026 17:20:55 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Jonathan Cameron" <jic23@...nel.org>, "Kurt Borja" <kuurtb@...il.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@...el.com>, "Lars-Peter Clausen"
 <lars@...afoo.de>, "Michael Hennerich" <Michael.Hennerich@...log.com>,
 "Benson Leung" <bleung@...omium.org>, "Antoniu Miclaus"
 <antoniu.miclaus@...log.com>, "Gwendal Grignou" <gwendal@...omium.org>,
 "Shrikant Raskar" <raskar.shree97@...il.com>, "Per-Daniel Olsson"
 <perdaniel.olsson@...s.com>, "David Lechner" <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>, "Andy Shevchenko"
 <andy@...nel.org>, "Guenter Roeck" <groeck@...omium.org>, "Jonathan
 Cameron" <Jonathan.Cameron@...wei.com>, <linux-iio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <chrome-platform@...ts.linux.dev>
Subject: Re: [PATCH v5 2/7] iio: core: Refactor iio_device_claim_direct()
 implementation

On Thu Jan 22, 2026 at 2:04 PM -05, Jonathan Cameron wrote:
> On Tue, 20 Jan 2026 01:20:42 -0500
> Kurt Borja <kuurtb@...il.com> wrote:
>
>> In order to eventually unify the locking API, implement
>> iio_device_claim_direct() fully inline, with the use of
>> __iio_dev_mode_lock(), which takes care of sparse annotations.
>> 
>> Reviewed-by: David Lechner <dlechner@...libre.com>
>> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
>> Signed-off-by: Kurt Borja <kuurtb@...il.com>
>
> So sparse does change what it moans about with this one in precisely one instance
> There are 9 false positives with Al Viro's updated sparse - I haven't checked the
> original one recently.

Hi Jonathan,

Upstream sparse is kinda broken right now.

I'm not getting any false positives on the locking stuff but a BUNCH of
"error: bad constant expresion" on MODULE_*() macros so I don't fully
trust it.

I know at least one subsystem maintainer is getting these too so I guess
it's an upstream problem.

>
> Anyhow, 
> drivers/iio/adc/ad7173.c:416:12: warning: context imbalance in 'ad7173_set_filter_type' - different lock contexts for basic block
> becomes
>
> drivers/iio/adc/ad7173.c:425:9: warning: context imbalance in 'ad7173_set_filter_type' - unexpected unlock                                                          

This one is interesting because I can't figure out why sparse hates it.

>
> Lets go with a bit meh for that and move on...
>

-- 
Thanks,
 ~ Kurt