linux-kernel - Re: [PATCH v5 5/7] iio: light: vcnl4000: Use IIO cleanup helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFVGW74ECJL3.1238NAUKM1U4B@gmail.com>
Date: Thu, 22 Jan 2026 17:22:26 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Jonathan Cameron" <jic23@...nel.org>, "Kurt Borja" <kuurtb@...il.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@...el.com>, "Lars-Peter Clausen"
 <lars@...afoo.de>, "Michael Hennerich" <Michael.Hennerich@...log.com>,
 "Benson Leung" <bleung@...omium.org>, "Antoniu Miclaus"
 <antoniu.miclaus@...log.com>, "Gwendal Grignou" <gwendal@...omium.org>,
 "Shrikant Raskar" <raskar.shree97@...il.com>, "Per-Daniel Olsson"
 <perdaniel.olsson@...s.com>, "David Lechner" <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>, "Andy Shevchenko"
 <andy@...nel.org>, "Guenter Roeck" <groeck@...omium.org>, "Jonathan
 Cameron" <Jonathan.Cameron@...wei.com>, <linux-iio@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <chrome-platform@...ts.linux.dev>
Subject: Re: [PATCH v5 5/7] iio: light: vcnl4000: Use IIO cleanup helpers

On Thu Jan 22, 2026 at 2:12 PM -05, Jonathan Cameron wrote:
> On Tue, 20 Jan 2026 01:20:45 -0500
> Kurt Borja <kuurtb@...il.com> wrote:
>
>> Use IIO_DEV_ACQUIRE_DIRECT_MODE() helper to automatically release direct
>> mode.
>> 
>> Reviewed-by: David Lechner <dlechner@...libre.com>
>> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
>> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> Given sparse doesn't play well with this stuff, this is (I think) more or less expected.
> drivers/iio/light/vcnl4000.c: note: in included file (through include/linux/iio/buffer.h):                                                                          
> ./include/linux/iio/iio.h:687:20: warning: context imbalance in 'vcnl4010_read_raw' - different lock contexts for basic block                                       
> ./include/linux/iio/iio.h:687:20: warning: context imbalance in 'vcnl4010_write_raw' - different lock contexts for basic block                                      
> ./include/linux/iio/iio.h:687:20: warning: context imbalance in 'vcnl4010_config_threshold' - different lock contexts for basic block   
>
> Hopefully it will one day catch up or we'll move to an alternative for lock checking.

Yep, sadly it's to be expected when using cleanup.h stuff.

>
> J

-- 
Thanks,
 ~ Kurt