linux-kernel - Re: [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon display controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4afa6f3110790c701c5e24901e9e66560cf21ad0.camel@icenowy.me>
Date: Thu, 22 Jan 2026 15:06:14 +0800
From: Icenowy Zheng <uwu@...nowy.me>
To: Thomas Zimmermann <tzimmermann@...e.de>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Rob
 Herring <robh@...nel.org>,  Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Drew Fustini <fustini@...nel.org>, Guo Ren
 <guoren@...nel.org>, Fu Wei <wefu@...hat.com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>, Dmitry Baryshkov
 <lumag@...nel.org>,  Michal Wilczynski <m.wilczynski@...sung.com>, Luca
 Ceresoli <luca.ceresoli@...tlin.com>, Han Gao <rabenda.cn@...il.com>,  Yao
 Zi <ziyao@...root.org>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org,  devicetree@...r.kernel.org,
 linux-riscv@...ts.infradead.org, Han Gao <gaohan@...as.ac.cn>
Subject: Re: [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon
 display controllers

在 2026-01-21星期三的 13:56 +0100，Thomas Zimmermann写道：

=============== 8< =================
> > +
> > +       if (irqs)
> > +               pr_warn("Unknown Verisilicon DC interrupt 0x%x
> > fired!\n", irqs);
> 
> I'd avoid pr_warn() here. This can fill your logs quickly.

Then is pr_warn_once() okay?

> 
> > +
> > +       return IRQ_HANDLED;
> > +}

=============== 8< =================

> > 
> > +       /* Fixup framebuffer address for src coordinates */
> > +       dma_addr += (state->src.x1 >> 16) * bpp;
> 
> bpp is deprecated and should be avoided in new code. You can compute
> the 
> offset with drm_format_min_pitch():
> 
> drm_format_min_pitch(fb->format, 0, state->src.x1 >> 16 )

Well it seems quite difficult to track what's deprecated in the DRM
subsystem, is there anything like a bulletin?


Thanks,
Icenowy