linux-kernel - Re: [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon display controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f49d5e01-1e01-4393-9ba3-2079006984ae@suse.de>
Date: Thu, 22 Jan 2026 08:31:01 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Icenowy Zheng <uwu@...nowy.me>, Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Drew Fustini <fustini@...nel.org>,
 Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>,
 Dmitry Baryshkov <lumag@...nel.org>,
 Michal Wilczynski <m.wilczynski@...sung.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>, Han Gao <rabenda.cn@...il.com>,
 Yao Zi <ziyao@...root.org>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-riscv@...ts.infradead.org, Han Gao <gaohan@...as.ac.cn>
Subject: Re: [PATCH v5 3/9] drm: verisilicon: add a driver for Verisilicon
 display controllers

Hi

Am 22.01.26 um 08:06 schrieb Icenowy Zheng:
> 在 2026-01-21星期三的 13:56 +0100，Thomas Zimmermann写道：
>
> =============== 8< =================
>>> +
>>> +       if (irqs)
>>> +               pr_warn("Unknown Verisilicon DC interrupt 0x%x
>>> fired!\n", irqs);
>> I'd avoid pr_warn() here. This can fill your logs quickly.
> Then is pr_warn_once() okay?

Yeah, warn_once should be fine.

>
>>> +
>>> +       return IRQ_HANDLED;
>>> +}
> =============== 8< =================

Maybe consider returning IRQ_NONE if the (irq) tests succeeds.

>
>>> +       /* Fixup framebuffer address for src coordinates */
>>> +       dma_addr += (state->src.x1 >> 16) * bpp;
>> bpp is deprecated and should be avoided in new code. You can compute
>> the
>> offset with drm_format_min_pitch():
>>
>> drm_format_min_pitch(fb->format, 0, state->src.x1 >> 16 )
> Well it seems quite difficult to track what's deprecated in the DRM
> subsystem, is there anything like a bulletin?

No, you either know or find out during the review. :) We also tend to 
leave comments in the code. [1]

[1] 
https://elixir.bootlin.com/linux/v6.18.6/source/include/drm/drm_fourcc.h#L82

Best regards
Thomas

>
>
> Thanks,
> Icenowy

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)