[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3e736769.79ad.19be4de9900.Coremail.andyshrk@163.com>
Date: Thu, 22 Jan 2026 16:42:32 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Nicolas Frattaroli" <nicolas.frattaroli@...labora.com>
Cc: "Harry Wentland" <harry.wentland@....com>, "Leo Li" <sunpeng.li@....com>,
"Rodrigo Siqueira" <siqueira@...lia.com>,
"Alex Deucher" <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
"David Airlie" <airlied@...il.com>,
"Simona Vetter" <simona@...ll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
"Maxime Ripard" <mripard@...nel.org>,
"Thomas Zimmermann" <tzimmermann@...e.de>,
"Andrzej Hajda" <andrzej.hajda@...el.com>,
"Neil Armstrong" <neil.armstrong@...aro.org>,
"Robert Foss" <rfoss@...nel.org>,
"Laurent Pinchart" <Laurent.pinchart@...asonboard.com>,
"Jonas Karlman" <jonas@...boo.se>,
"Jernej Skrabec" <jernej.skrabec@...il.com>,
"Sandy Huang" <hjc@...k-chips.com>,
Heiko Stübner <heiko@...ech.de>,
"Andy Yan" <andy.yan@...k-chips.com>,
"Jani Nikula" <jani.nikula@...ux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@...el.com>,
"Joonas Lahtinen" <joonas.lahtinen@...ux.intel.com>,
"Tvrtko Ursulin" <tursulin@...ulin.net>,
"Dmitry Baryshkov" <lumag@...nel.org>,
"Sascha Hauer" <s.hauer@...gutronix.de>,
"Rob Herring" <robh@...nel.org>, "Jonathan Corbet" <corbet@....net>,
kernel@...labora.com, amd-gfx@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, intel-gfx@...ts.freedesktop.org,
intel-xe@...ts.freedesktop.org, linux-doc@...r.kernel.org
Subject: Re:[PATCH v7 12/22] drm/rockchip: vop2: Recognise 10/12-bit YUV422
as YUV formats
Hello Nicolas,
At 2026-01-21 22:45:19, "Nicolas Frattaroli" <nicolas.frattaroli@...labora.com> wrote:
>The Rockchip VOP2 video output driver has a "is_yuv_output" function,
>which returns true when a given bus format is a YUV format, and false
>otherwise.
>
>This switch statement is lacking the bus format used for YUV422 10-bit,
>as well as the bus format used for YUV422 12-bit.
>
>Add MEDIA_BUS_FMT_YUYV10_1X20 and MEDIA_BUS_FMT_YUYV12_1X24 to
>is_yuv_output's switch cases to resolve this.
>
>Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
>Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
>---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>index f21efbca42e6..3dd7b7571487 100644
>--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>@@ -369,6 +369,9 @@ static bool is_yuv_output(u32 bus_format)
> switch (bus_format) {
> case MEDIA_BUS_FMT_YUV8_1X24:
> case MEDIA_BUS_FMT_YUV10_1X30:
>+ case MEDIA_BUS_FMT_YUYV10_1X20:
>+ case MEDIA_BUS_FMT_UYVY10_1X20:
>+ case MEDIA_BUS_FMT_YUYV12_1X24:
MEDIA_BUS_FMT_YUYV12_1X24 is not supported by VOP, the max output depth of VOP is 10
> case MEDIA_BUS_FMT_UYYVYY8_0_5X24:
> case MEDIA_BUS_FMT_UYYVYY10_0_5X30:
> case MEDIA_BUS_FMT_YUYV8_2X8:
>
>--
>2.52.0
>
Powered by blists - more mailing lists