linux-kernel - Re:[PATCH v7 13/22] drm/rockchip: vop2: Set correct output format for RK3576 YUV422

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27c44445.7a56.19be4e04fa9.Coremail.andyshrk@163.com>
Date: Thu, 22 Jan 2026 16:44:24 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Nicolas Frattaroli" <nicolas.frattaroli@...labora.com>
Cc: "Harry Wentland" <harry.wentland@....com>, "Leo Li" <sunpeng.li@....com>,
	"Rodrigo Siqueira" <siqueira@...lia.com>,
	"Alex Deucher" <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	"David Airlie" <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>,
	"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
	"Maxime Ripard" <mripard@...nel.org>,
	"Thomas Zimmermann" <tzimmermann@...e.de>,
	"Andrzej Hajda" <andrzej.hajda@...el.com>,
	"Neil Armstrong" <neil.armstrong@...aro.org>,
	"Robert Foss" <rfoss@...nel.org>,
	"Laurent Pinchart" <Laurent.pinchart@...asonboard.com>,
	"Jonas Karlman" <jonas@...boo.se>,
	"Jernej Skrabec" <jernej.skrabec@...il.com>,
	"Sandy Huang" <hjc@...k-chips.com>,
	Heiko Stübner <heiko@...ech.de>,
	"Andy Yan" <andy.yan@...k-chips.com>,
	"Jani Nikula" <jani.nikula@...ux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@...el.com>,
	"Joonas Lahtinen" <joonas.lahtinen@...ux.intel.com>,
	"Tvrtko Ursulin" <tursulin@...ulin.net>,
	"Dmitry Baryshkov" <lumag@...nel.org>,
	"Sascha Hauer" <s.hauer@...gutronix.de>,
	"Rob Herring" <robh@...nel.org>, "Jonathan Corbet" <corbet@....net>,
	kernel@...labora.com, amd-gfx@...ts.freedesktop.org,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, intel-gfx@...ts.freedesktop.org,
	intel-xe@...ts.freedesktop.org, linux-doc@...r.kernel.org
Subject: Re:[PATCH v7 13/22] drm/rockchip: vop2: Set correct output format
 for RK3576 YUV422



Hello Nicolas,

At 2026-01-21 22:45:20, "Nicolas Frattaroli" <nicolas.frattaroli@...labora.com> wrote:
>For RK3576 to be able to output YUV422 signals, it first needs to be
>able to pick the right output mode in the display controller to do so.
>
>The RK3576 hardware specifies different output formats depending on the
>used display protocol.
>
>Adjust the written register value based on the SoC and connector, so
>other users of vcstate->output_mode don't have to care about this.
>
>Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>


    Reviewed-by: Andy Yan <andyshrk@....com>
>---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
>diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>index 3dd7b7571487..d93c6779286e 100644
>--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
>@@ -1706,6 +1706,22 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
> 	if (vcstate->output_mode == ROCKCHIP_OUT_MODE_AAAA &&
> 	    !(vp_data->feature & VOP2_VP_FEATURE_OUTPUT_10BIT))
> 		out_mode = ROCKCHIP_OUT_MODE_P888;
>+	else if (vcstate->output_mode == ROCKCHIP_OUT_MODE_YUV422 &&
>+		 vop2->version == VOP_VERSION_RK3576)
>+		switch (vcstate->output_type) {
>+		case DRM_MODE_CONNECTOR_DisplayPort:
>+		case DRM_MODE_CONNECTOR_eDP:
>+			out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_DP;
>+			break;
>+		case DRM_MODE_CONNECTOR_HDMIA:
>+			out_mode = ROCKCHIP_OUT_MODE_YUV422_RK3576_HDMI;
>+			break;
>+		default:
>+			drm_err(vop2->drm, "Unknown DRM_MODE_CONNECTOR %d\n",
>+				vcstate->output_type);
>+			vop2_unlock(vop2);
>+			return;
>+		}
> 	else
> 		out_mode = vcstate->output_mode;
> 
>
>-- 
>2.52.0
>