[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260122101122-GYA63789@gentoo.org>
Date: Thu, 22 Jan 2026 18:11:22 +0800
From: Yixun Lan <dlan@...too.org>
To: Guodong Xu <guodong@...cstar.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Alex Elder <elder@...cstar.com>, Lee Jones <lee@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
spacemit@...ts.linux.dev, devicetree@...r.kernel.org
Subject: Re: [PATCH 0/4] regulator: spacemit-p1: Fix voltage ranges and
support board power tree
Hi Guodong,
On 17:43 Thu 22 Jan , Guodong Xu wrote:
> This series fixes hardware voltage constraints and enables flexible power
> tree configurations for the SpacemiT P1 PMIC.
>
> Patch 1, n_voltages is corrected to match hardware register widths, as the
> previous values prevented regulators from reaching higher operational
> voltages (e.g., 3.3V on LDOs).
>
> Patch 2-4, hardcoded supply assumptions are replaced with explicit
> devicetree properties. PMIC supply connections are board-design decisions.
> Moving this to DT allows supporting varied topologies without driver
> modifications.
>
> Note: Patch 3 introduces a bisect breakage by transitioning to
> pin-specific supply names. Probe failures will occur on existing board
> (K1 Bananapi F3) until Patch 4 updates the corresponding DTS file.
This patch bring system-wide change that not only affect Bananapi F3..
Please also provide fix for other boards, I think you may not be able
to test all boards, but make sure the patches are available, so people
who interested can test, P.S I can help on milkv jupiter board
>
> Signed-off-by: Guodong Xu <guodong@...cstar.com>
> ---
> Guodong Xu (4):
> regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators
> dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties
> regulator: spacemit-p1: Update supply names
> riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties
>
> .../devicetree/bindings/mfd/spacemit,p1.yaml | 58 +++++++++++++++++++++-
> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 12 ++++-
> drivers/regulator/spacemit-p1.c | 25 ++++++----
> 3 files changed, 80 insertions(+), 15 deletions(-)
> ---
> base-commit: c8a4a774a9b0d2c86593492625874e27e9cbc9a9
> change-id: 20260122-spacemit-p1-ae596efe885f
>
> Best regards,
> --
> Guodong Xu <guodong@...cstar.com>
>
--
Yixun Lan (dlan)
Powered by blists - more mailing lists