linux-kernel - Re: [PATCH 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <176907723670.1588257.5123730065899244337.robh@kernel.org>
Date: Thu, 22 Jan 2026 04:20:36 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Guodong Xu <guodong@...cstar.com>
Cc: linux-kernel@...r.kernel.org, spacemit@...ts.linux.dev, 
 Liam Girdwood <lgirdwood@...il.com>, Conor Dooley <conor+dt@...nel.org>, 
 Palmer Dabbelt <palmer@...belt.com>, 
 Troy Mitchell <troy.mitchell@...ux.spacemit.com>, 
 Paul Walmsley <pjw@...nel.org>, Alexandre Ghiti <alex@...ti.fr>, 
 Lee Jones <lee@...nel.org>, Alex Elder <elder@...cstar.com>, 
 devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org, 
 Yixun Lan <dlan@...too.org>, Albert Ou <aou@...s.berkeley.edu>, 
 Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH 2/4] dt-bindings: mfd: spacemit,p1: Add individual
 regulator supply properties

On Thu, 22 Jan 2026 17:43:43 +0800, Guodong Xu wrote:
> Add supply properties that match the P1 PMIC's actual hardware topology
> where each buck converter has its own VIN pin and LDO groups share
> common input pins. Supply names are defined according to the pinout
> names in the P1 datasheet.
> 
> This allows different boards to describe their actual
> power tree connections in devicetree rather than hardcoding supply
> relationships in the driver.
> 
> Signed-off-by: Guodong Xu <guodong@...cstar.com>
> ---
>  .../devicetree/bindings/mfd/spacemit,p1.yaml       | 58 +++++++++++++++++++++-
>  1 file changed, 56 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/mfd/spacemit,p1.example.dts:13.1-4 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:141: Documentation/devicetree/bindings/mfd/spacemit,p1.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1559: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260122-spacemit-p1-v1-2-309be27fbff9@riscstar.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.