linux-kernel - Re: [PATCH v3] spi: xilinx: use device property accessors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a979b1eb-87c9-4c08-8d30-0fe18ad07a26@sirena.org.uk>
Date: Fri, 23 Jan 2026 12:40:32 +0000
From: Mark Brown <broonie@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: Andrew Lunn <andrew@...n.ch>, abdurrahman@...thop.ai,
	linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] spi: xilinx: use device property accessors.

On Fri, Jan 23, 2026 at 08:11:47AM +0100, Michal Simek wrote:
> On 1/22/26 17:18, Andrew Lunn wrote:
> > On Thu, Jan 22, 2026 at 09:00:29AM +0000, Abdurrahman Hussain via B4 Relay wrote:

> > > +		ret = device_property_read_u32(&pdev->dev,
> > > +					       "xlnx,num-transfer-bits",
> > > +					       &bits_per_word);

> > It could be my grep foo is broken, but there does not appear to be any
> > users of xlnx,num-transfer-bits and xlnx,num-ss-bits. So it would be
> > better to just remove them. There is no point Maintaining an API
> > nobody uses. And it would be silly to spread that API to ACPI if
> > nobody it going to use it.

There are no upstream users of this driver at all so obviously no use of
the properties.

> "xlnx,num-transfer-bits"
> bits_per_word is initializing bytes_per_word which is used in code for
> transfer sizes calculations.

The example AML posted was setting xlnx,num-transfer-bits to the default
value of 8 bits FWIW.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)