linux-kernel - Re: [PATCH v3] spi: xilinx: use device property accessors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0310e06-4a50-47e8-9de7-581eff6f53ec@amd.com>
Date: Fri, 23 Jan 2026 15:14:22 +0100
From: Michal Simek <michal.simek@....com>
To: Mark Brown <broonie@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, abdurrahman@...thop.ai,
 linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] spi: xilinx: use device property accessors.

On 1/23/26 13:40, Mark Brown wrote:
> On Fri, Jan 23, 2026 at 08:11:47AM +0100, Michal Simek wrote:
>> On 1/22/26 17:18, Andrew Lunn wrote:
>>> On Thu, Jan 22, 2026 at 09:00:29AM +0000, Abdurrahman Hussain via B4 Relay wrote:
> 
>>>> +		ret = device_property_read_u32(&pdev->dev,
>>>> +					       "xlnx,num-transfer-bits",
>>>> +					       &bits_per_word);
> 
>>> It could be my grep foo is broken, but there does not appear to be any
>>> users of xlnx,num-transfer-bits and xlnx,num-ss-bits. So it would be
>>> better to just remove them. There is no point Maintaining an API
>>> nobody uses. And it would be silly to spread that API to ACPI if
>>> nobody it going to use it.
> 
> There are no upstream users of this driver at all so obviously no use of
> the properties.

We are not wiring this driver in any DT because it is soft IP but it doesn't 
mean that it is not used.
But as you see Abdurrahman is able to use this driver is one configuration.
These properties are stable for years and well documented.

Thanks,
Michal