linux-kernel - Re: [PATCH v5 2/2] i2c: designware-platdrv: refactor error handling and simplify cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d802354283652410ebfbe7717716bb347d7dba25.camel@pengutronix.de>
Date: Fri, 23 Jan 2026 13:48:14 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Artem Shimko <a.shimko.dev@...il.com>, Mika Westerberg	
 <mika.westerberg@...ux.intel.com>, Andy Shevchenko	
 <andriy.shevchenko@...ux.intel.com>, Jan Dabros <jsd@...ihalf.com>, Andi
 Shyti	 <andi.shyti@...nel.org>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] i2c: designware-platdrv: refactor error handling
 and simplify cleanup

On Fr, 2026-01-23 at 13:05 +0300, Artem Shimko wrote:
> Streamline the probe error handling by replacing goto statements with
> direct returns and using dev_err_probe() for consistent error reporting.
> This results in more linear and readable control flow.
> 
> Remove the explicit reset_control_assert() call from the driver's
> remove function, as the reset controller is acquired with
> devm_reset_control_get_optional_exclusive_deasserted() which manages
> the reset state automatically through devm resource management.

This change belongs in patch 1, same with the assert in the  probe
error path.

regards
Philipp