linux-kernel - Re: [PATCH v5 2/2] i2c: designware-platdrv: refactor error handling and simplify cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOPX747KPUFyXiCjAj-Nf4z-LWNiyiGoaamu=QEaUrfBh1Y3Ew@mail.gmail.com>
Date: Fri, 23 Jan 2026 19:09:20 +0300
From: Artem Shimko <a.shimko.dev@...il.com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jan Dabros <jsd@...ihalf.com>, 
	Andi Shyti <andi.shyti@...nel.org>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] i2c: designware-platdrv: refactor error handling
 and simplify cleanup

On Fri, Jan 23, 2026 at 3:48 PM Philipp Zabel <p.zabel@...gutronix.de> wrote:
>
> On Fr, 2026-01-23 at 13:05 +0300, Artem Shimko wrote:
> > Streamline the probe error handling by replacing goto statements with
> > direct returns and using dev_err_probe() for consistent error reporting.
> > This results in more linear and readable control flow.
> >
> > Remove the explicit reset_control_assert() call from the driver's
> > remove function, as the reset controller is acquired with
> > devm_reset_control_get_optional_exclusive_deasserted() which manages
> > the reset state automatically through devm resource management.
>
> This change belongs in patch 1, same with the assert in the  probe
> error path.

Hi Philipp,

You're absolutely right. I misunderstood Andy's earlier feedback in [1].
He was specifically referring to separating the dw_i2c_plat_pm_cleanup
change into its own patch, not the reset_control_assert() changes.

I'll fix it.

Thank you.

[1] https://lore.kernel.org/all/20251111075400.2982270-1-a.shimko.dev@gmail.com/T/#u

Regards,
artem