[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2026012343-rockfish-candle-d3d9@gregkh>
Date: Fri, 23 Jan 2026 17:19:06 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Jan Remmet <j.remmet@...tec.de>
Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
upstream@...ts.phytec.de
Subject: Re: [PATCH v2] usb: typec: hd3ss3220: Enable VBUS based on role state
On Fri, Jan 23, 2026 at 03:52:37PM +0100, Jan Remmet wrote:
> For systems where the ID pin isn't available as gpio use the ATTACHED_STATE
> register instead to control vbus.
>
> >From the datasheet:
> "This is an additional method to communicate attach other
> than the ID pin. These bits can be read by the application to
> determine what was attached."
>
> Use this method if id-gpios property is not set, but the connector node
> has vbus-supply defined.
>
> Check regulator state as peripheral and detach can disable vbus.
>
> Signed-off-by: Jan Remmet <j.remmet@...tec.de>
> ---
> Changes in v2:
> - Added check if regulator is already disabled. As detach and
> peripheral mode cause an interrupt.
> - Link to v1: https://lore.kernel.org/r/20260115-wip-jremmet-hd3ss3220_vbus-v1-1-b7d9adfbe346@phytec.de
> ---
> drivers/usb/typec/hd3ss3220.c | 30 +++++++++++++++++++++---------
> 1 file changed, 21 insertions(+), 9 deletions(-)
Does not apply against my tree, what did you make it against? Can you
redo this against linux-next and resend?
thanks,
greg k-h
Powered by blists - more mailing lists