[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <000e01dc8c3a$05fa3df0$11eeb9d0$@samsung.com>
Date: Fri, 23 Jan 2026 12:59:26 +0530
From: "Pritam Manohar Sutar" <pritam.sutar@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <alim.akhtar@...sung.com>
Cc: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<rosa.pila@...sung.com>, <dev.tailor@...sung.com>, <faraz.ata@...sung.com>,
<muhammed.ali@...sung.com>, <selvarasu.g@...sung.com>
Subject: RE: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
nodes
Hi
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 22 January 2026 07:05 PM
> To: Pritam Manohar Sutar <pritam.sutar@...sung.com>; robh@...nel.org;
> krzk+dt@...nel.org; conor+dt@...nel.org; alim.akhtar@...sung.com
> Cc: devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org;
> rosa.pila@...sung.com; dev.tailor@...sung.com;
> faraz.ata@...sung.com; muhammed.ali@...sung.com;
> selvarasu.g@...sung.com
> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
> nodes
>
> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
> > Enable USB PHY and DWC3 USB controllers' nodes.
> >
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@...sung.com>
> > ---
> > .../boot/dts/exynos/exynosautov920-sadk.dts | 21
> +++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > index f90f7704597c..5896dd69334a 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> > @@ -160,15 +160,20 @@ &xtcxo {
> > &usbdrd31_ssphy {
> > dvdd-supply = <&dummy_regulator>;
> > vdd18-supply = <&dummy_regulator>;
> > + status = "okay";
>
> You just added the node in the previous patch, so why it cant be enavled
> there?
>
> > };
> >
> > &usbdrd31_hsphy {
> > dvdd-supply = <&dummy_regulator>;
> > vdd18-supply = <&dummy_regulator>;
> > vdd33-supply = <&dummy_regulator>;
> > + status = "okay";
> > };
> >
> > &usbdrd31_dwc3 {
> > + dr_mode = "otg";
> > + usb-role-switch;
> > + role-switch-default-mode = "peripheral";
>
> Why did you add incomplete node in previous commit?
>
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists