linux-kernel - Re: [PATCH] staging: rtl8723bs: fix coding style issues in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXM34ZGQ4Q2dsRxk@stanley.mountain>
Date: Fri, 23 Jan 2026 11:57:05 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Michael Huang <tehsiu.huang@...il.com>
Cc: gregkh@...uxfoundation.org, straube.linux@...il.com, hansg@...nel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix coding style issues in rtw_mlme.c

On Thu, Jan 22, 2026 at 04:32:05PM -0800, Michael Huang wrote:
> This patch fixes several checkpatch.pl issues:
> 1. Remove redundant else after break/return.
> 2. Remove unnecessary boolean comparisons (== true/false).
> 3. Fix trailing whitespaces and overly deep indentation.
> 
> Signed-off-by: Michael Huang <tehsiu.huang@...il.com>

Split this up into multiple patches.

> @@ -1560,10 +1559,6 @@ void _rtw_join_timeout_handler(struct timer_list *t)
>  				do_join_r = rtw_do_join(adapter);
>  				if (do_join_r != _SUCCESS)
>  					continue;
> -
> -				break;
> -			} else {
> -				rtw_indicate_disconnect(adapter);
>  				break;
>  			}
>  		}

You accidentally deleted some important stuff here.

regards,
dan carpenter