linux-kernel - Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14a71b33-4c10-41b0-a6cb-585a38e05f56@kernel.org>
Date: Fri, 23 Jan 2026 09:57:12 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harshal Dev <harshal.dev@....qualcomm.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Abel Vesa <abel.vesa@....qualcomm.com>, cros-qcom-dts-watchers@...omium.org
Cc: Brian Masney <bmasney@...hat.com>,
 Neeraj Soni <neeraj.soni@....qualcomm.com>,
 Gaurav Kashyap <gaurav.kashyap@....qualcomm.com>,
 linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/11] dt-bindings: crypto: qcom,ice: Require power-domain
 and iface clk

On 23/01/2026 08:11, Harshal Dev wrote:
> Update the inline-crypto engine DT binding to reflect that power-domain and
> clock-names are now mandatory. Also update the maximum number of clocks
> that can be specified to two. These new fields are mandatory because ICE
> needs to vote on the power domain before it attempts to vote on the core
> and iface clocks to avoid clock 'stuck' issues.
> 
> Signed-off-by: Harshal Dev <harshal.dev@....qualcomm.com>
> ---
>  .../bindings/crypto/qcom,inline-crypto-engine.yaml         | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> index c3408dcf5d20..1c2416117d4c 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> @@ -28,12 +28,20 @@ properties:
>      maxItems: 1
>  
>    clocks:
> +    maxItems: 2

This is ABI break and your commit msg suggests things were not perfect,
but it is not explicit - was this working or not? How is it that ICE was
never tested?

> +
> +  clock-names:
> +    maxItems: 2

Why "yellowpony" is a correct name? Please look at existing code to see
how this is done.

> +
> +  power-domains:
>      maxItems: 1
>  
>  required:
>    - compatible
>    - reg
>    - clocks
> +  - clock-names
> +  - power-domains

Another ABI break...

Best regards,
Krzysztof