linux-kernel - Re: [PATCH v6 1/5] iio: proximity: rfd77402: Reorder header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260123095936.27efdeb4@jic23-huawei>
Date: Fri, 23 Jan 2026 09:59:36 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Shrikant <raskar.shree97@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, skhan@...uxfoundation.org,
 david.hunter.linux@...il.com, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/5] iio: proximity: rfd77402: Reorder header
 includes

On Fri, 23 Jan 2026 09:12:31 +0530
Shrikant <raskar.shree97@...il.com> wrote:

> On Fri, Jan 23, 2026 at 2:27 AM Jonathan Cameron <jic23@...nel.org> wrote:
> >
> > On Wed, 21 Jan 2026 10:54:00 +0200
> > Andy Shevchenko <andriy.shevchenko@...el.com> wrote:
> >  
> > > On Wed, Jan 21, 2026 at 02:05:41AM +0530, Shrikant Raskar via B4 Relay wrote:
> > >  
> > > > Reorder header includes to follow kernel include
> > > > ordering conventions.  
> > >
> > > FWIW,
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> > >  
> >
> > Patches 1 and 2 were already queued up.  I've rebuilt the merge
> > in my tree to drop patch 2 without breaking the rest of the history.
> >
> > Shrikant, it is common for maintainer to pick up the early
> > part of a series whilst later parts still need more work.
> > If that happens, please rebase on the appropriate tree or
> > just drop those patches form your series that have already been
> > applied. Otherwise this mess happens where new review comes
> > in. Review is always good, but it should be clear if it
> > is on applied patches or not!
> >  
> Sorry for creating the confusion, the patches 1 and 2 which were
> applied in v4 were dropped from v5 onwards as per your suggestion.
> Please see the links of the accepted patches for your reference.
> 1. https://lore.kernel.org/all/20260101-b4-rfd77402_irq-v4-1-42cd54359e9f@gmail.com/
> 2. https://lore.kernel.org/all/20260101-b4-rfd77402_irq-v4-2-42cd54359e9f@gmail.com/
> 
> As per reviewer comments , I have split the existing patches into
> multiple commits like:
> 1. Added pre-cursor commit for include order
> 2. Added separate commit for devm mutex initialization
> 3. Added separate commit for kernel-doc for privata data.
> 
> Because of these separated commits, the total number of
> patches in series are still 5.
Ah ok so in general good. I guess you missed that I mailed to say I picked up a few
more in v5.
https://lore.kernel.org/all/20260116200921.7494025b@jic23-huawei/

These things happen so don't worry about it. I was just grumpy last night :(

Feeling much better now I've spent a few more hours getting on top of the
backlog for this cycle!

Jonathan
> 
> Regards,
> Shrikant
>