linux-kernel - [PATCH v2 2/2] staging: rtl8723bs: remove redundant else after break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260123095733.49301-3-tehsiu.huang@gmail.com>
Date: Fri, 23 Jan 2026 01:57:33 -0800
From: Michael Huang <tehsiu.huang@...il.com>
To: gregkh@...uxfoundation.org
Cc: dan.carpenter@...aro.org,
	straube.linux@...il.com,
	hansg@...nel.org,
	linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Michael Huang <tehsiu.huang@...il.com>
Subject: [PATCH v2 2/2] staging: rtl8723bs: remove redundant else after break

In _rtw_join_timeout_handler(), an else statement followed a break
in the previous logic. Removing this else reduces the indentation
level of the following code and makes the function easier to read,
while maintaining the original logic by ensuring that disconnect
indication is still called when roaming fails.

Signed-off-by: Michael Huang <tehsiu.huang@...il.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index ed754fdbfe7a..ac47b2a4f65f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -1559,12 +1559,10 @@ void _rtw_join_timeout_handler(struct timer_list *t)
 				do_join_r = rtw_do_join(adapter);
 				if (do_join_r != _SUCCESS)
 					continue;
-
-				break;
-			} else {
-				rtw_indicate_disconnect(adapter);
 				break;
 			}
+			rtw_indicate_disconnect(adapter);
+			break;
 		}
 
 	} else {
-- 
2.43.0