lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2026012726-connected-eloquence-572b@gregkh>
Date: Tue, 27 Jan 2026 15:42:43 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Michael Huang <tehsiu.huang@...il.com>
Cc: dan.carpenter@...aro.org, straube.linux@...il.com, hansg@...nel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: remove unnecessary boolean
 comparisons and whitespaces

On Fri, Jan 23, 2026 at 01:57:32AM -0800, Michael Huang wrote:
> According to the kernel coding style, explicit comparisons with true
> or false are redundant and should be avoided. This patch removes these
> comparisons in rtw_mlme.c to improve code clarity. Additionally,
> trailing whitespaces are removed to satisfy checkpatch.pl requirements.

That is two different things in one patch, please do not do that.
Remember, only one logical change per patch.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ