linux-kernel - Re: [PATCH bpf-next v6 4/4] selftests/bpf: Add tests for signature verification kfuncs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <hk2e2og5v347kmuyyegilgejktgafjgvbxopfk4a2lippmggch@nzuoznk376s3>
Date: Sun, 25 Jan 2026 07:34:57 -0500
From: Daniel Hodges <daniel@...ielhodges.dev>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc: Daniel Hodges <git@...ielhodges.dev>, bpf <bpf@...r.kernel.org>, 
	Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Song Liu <song@...nel.org>, Mykyta Yatsenko <yatsenko@...a.com>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard <eddyz87@...il.com>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, 
	Yonghong Song <yonghong.song@...ux.dev>, Herbert Xu <herbert@...dor.apana.org.au>, 
	"David S. Miller" <davem@...emloft.net>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH bpf-next v6 4/4] selftests/bpf: Add tests for signature
 verification kfuncs

> > Signed-off-by: Daniel Hodges <git@...ielhodges.dev>
> > ---
> >  MAINTAINERS                                   |   2 +
> >  .../selftests/bpf/prog_tests/sig_verify.c     | 163 ++++++++++
> >  .../selftests/bpf/progs/crypto_common.h       |   6 +
> >  .../testing/selftests/bpf/progs/sig_verify.c  | 286 ++++++++++++++++++
> >  4 files changed, 457 insertions(+)
> >  create mode 100644 tools/testing/selftests/bpf/prog_tests/sig_verify.c
> >  create mode 100644 tools/testing/selftests/bpf/progs/sig_verify.c
> 
> It's a v6 already, but your new selftests are still failing in CI.
> 
> Error: #385 sig_verify
> Error: #385/1 sig_verify/verify_valid_signature
> Error: #385/3 sig_verify/size_queries
> Error: #385/6 sig_verify/zero_len_msg
> Error: #385/7 sig_verify/zero_len_sig
> 
> Please make sure CI is green before submitting v7.
> No one is reviewing the patches when they don't pass their own tests.

Noted, sorry about that. I think my local vm has some different config:

vng -- ./tools/testing/selftests/bpf/test_progs -t sig_verify
WARNING! Selftests relying on bpf_testmod.ko will be skipped.
Can't find bpf_testmod.ko kernel module: -2
#385/1   sig_verify/verify_valid_signature:OK
#385/2   sig_verify/verify_invalid_signature:OK
#385/3   sig_verify/size_queries:OK
#385/4   sig_verify/ecdsa_on_hash_ctx:OK
#385/5   sig_verify/ecdsa_keysize_on_hash_ctx:OK
#385/6   sig_verify/zero_len_msg:OK
#385/7   sig_verify/zero_len_sig:OK
#385     sig_verify:OK
Summary: 1/7 PASSED, 0 SKIPPED, 0 FAILED

I'll figure it out properly, thanks for the direction!