linux-kernel - Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026012647-overheat-elm-aecc@gregkh>
Date: Mon, 26 Jan 2026 15:32:31 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ethan Tidmore <ethantidmore06@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Michael Straube <straube.linux@...il.com>,
	Hans de Goede <hansg@...nel.org>,
	Akiyoshi Kurita <weibu@...admin.org>,
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v1] staging: rtl8723bs: rename members of struct
 registry_priv

On Mon, Jan 26, 2026 at 08:15:43AM -0600, Ethan Tidmore wrote:
> Rename CamelCase members of struct registry_priv to snake_case to
> comply with the Linux kernel coding style.

Close, but:

> +	u8 b_en_rfe;

What does the "b_" here mean?  The original variable name had it, but
that was because it was attempting to do a "hungarian notation" type of
name, which is not the correct way to name Linux kernel variables,
sorry.

Also:
> --- a/drivers/staging/rtl8723bs/include/hal_com_phycfg.h
> +++ b/drivers/staging/rtl8723bs/include/hal_com_phycfg.h
> @@ -90,7 +90,7 @@ void PHY_TxPowerByRateConfiguration(struct adapter *padapter);
>  u8 PHY_GetTxPowerIndexBase(struct adapter *padapter, u8 RFPath, u8 Rate,
>  			   enum channel_width BandWidth, u8 Channel);
>  
> -s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 RegPwrTblSel,
> +s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,

That was not a change needed do to the structure name changes.  Please
only do one logical change per patch.  Maybe one per variable name
change to make it more obvious and easy to review?

thanks,

greg k-h