linux-kernel - Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fr7scqxl.ffs@tglx>
Date: Mon, 26 Jan 2026 16:52:06 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: Janne Grunau <j@...nau.net>, Sven Peter <sven@...nel.org>, Neal Gompa
 <neal@...pa.dev>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, Janne Grunau
 <j@...nau.net>
Subject: Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"

On Sun, Jan 25 2026 at 12:08, Janne Grunau wrote:
> +/*
> + * AIC v3 registers (MMIO)
> + */
> + 

Pointless newline and please make this a /* Oneline comment */

> +#define AIC3_IRQ_CFG		0x10000
> +
>  	}
> +	case 3:
>  	case 2: {

1 3 2 is a weird count order...

Thanks,

        tglx