linux-kernel - Re: [PATCH] arm64: dts: qcom: talos: Add missing clock-names to GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pjambgdh3fh2ypbun5qnmcpwrz2ajbiulcz64g7epegjy2j4eh@a2zkzepj5ro3>
Date: Mon, 26 Jan 2026 19:53:44 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Lijuan Gao <quic_lijuang@...cinc.com>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: talos: Add missing clock-names to GCC

On Mon, Jan 26, 2026 at 02:46:20PM +0100, Konrad Dybcio wrote:
> On 1/26/26 2:33 PM, Dmitry Baryshkov wrote:
> > On Mon, Jan 26, 2026 at 10:45:03AM +0100, Konrad Dybcio wrote:
> >> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> >>
> >> The binding for this clock controller requires that clock-names are
> >> present. They're not really used by the kernel driver, but they're
> >> marked as required, so someone might have assumed it's done on purpose
> >> (where in reality we try to stay away from that since index-based
> >> references are faster, take up less space and are already widely used)
> >> and referenced it in drivers for another OS.
> >>
> >> Hence, do the least painful thing and add the missing entries.
> > 
> > One (me included) would assume that the presense of clock-names imples
> > that the clocks are fetched according to those names and become very
> > surprised if they are not. As such I'd suggest fixing the bindings instead.
> 
> The reason why I chose otherwise is in the commit message

Should we then change the driver to also start using clock-names?

> Let's try to review bindings better next time


-- 
With best wishes
Dmitry