linux-kernel - Re: [PATCH] arm64: dts: qcom: talos: Add missing clock-names to GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ispsq6ntw47gf5befoe3kpomhnsszolnxbzqpwzu36dr4jbbow@zepv7cxdbsez>
Date: Mon, 26 Jan 2026 14:42:12 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Lijuan Gao <quic_lijuang@...cinc.com>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: talos: Add missing clock-names to GCC

On Mon, Jan 26, 2026 at 07:53:44PM +0200, Dmitry Baryshkov wrote:
> On Mon, Jan 26, 2026 at 02:46:20PM +0100, Konrad Dybcio wrote:
> > On 1/26/26 2:33 PM, Dmitry Baryshkov wrote:
> > > On Mon, Jan 26, 2026 at 10:45:03AM +0100, Konrad Dybcio wrote:
> > >> From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> > >>
> > >> The binding for this clock controller requires that clock-names are
> > >> present. They're not really used by the kernel driver, but they're
> > >> marked as required, so someone might have assumed it's done on purpose
> > >> (where in reality we try to stay away from that since index-based
> > >> references are faster, take up less space and are already widely used)
> > >> and referenced it in drivers for another OS.
> > >>
> > >> Hence, do the least painful thing and add the missing entries.
> > > 
> > > One (me included) would assume that the presense of clock-names imples
> > > that the clocks are fetched according to those names and become very
> > > surprised if they are not. As such I'd suggest fixing the bindings instead.
> > 
> > The reason why I chose otherwise is in the commit message
> 
> Should we then change the driver to also start using clock-names?
> 

That's not necessary.

The binding does define that the DeviceTree must contain clock-names,
but it doesn't mandate any implementation to actually consider this
information.

Given that the order of the entries in the "clocks" property is defined
by the binding an implementation can choose to rely on that and ignore
the clock-names.

Regards,
Bjorn

> > Let's try to review bindings better next time
> 
> 
> -- 
> With best wishes
> Dmitry