linux-kernel - Re: [PATCH v1 4/5] gpu: nova-core: use checked arithmetic in BinFirmware::data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260126100108.7f65d262.zhiw@nvidia.com>
Date: Mon, 26 Jan 2026 10:01:08 +0200
From: Zhi Wang <zhiw@...dia.com>
To: Joel Fernandes <joelagnelf@...dia.com>
CC: <linux-kernel@...r.kernel.org>, Danilo Krummrich <dakr@...nel.org>,
	Alexandre Courbot <acourbot@...dia.com>, Alice Ryhl <aliceryhl@...gle.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Alistair
 Popple" <apopple@...dia.com>, Bjorn Helgaas <bhelgaas@...gle.com>, "Miguel
 Ojeda" <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng
	<boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, "Björn
 Roy Baron" <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>,
	<nouveau@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v1 4/5] gpu: nova-core: use checked arithmetic in
 BinFirmware::data

On Sat, 24 Jan 2026 18:18:29 -0500
Joel Fernandes <joelagnelf@...dia.com> wrote:

> Use checked_add() when computing the firmware data end offset in the
> BinFirmware::data() method. The data_offset and data_size fields come
> from the BinHdr structure parsed from the firmware file header.
> 
> Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
> ---
>  drivers/gpu/nova-core/firmware.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/nova-core/firmware.rs
> b/drivers/gpu/nova-core/firmware.rs index 68779540aa28..4f57a270e142
> 100644 --- a/drivers/gpu/nova-core/firmware.rs
> +++ b/drivers/gpu/nova-core/firmware.rs
> @@ -394,8 +394,9 @@ fn new(fw: &'a firmware::Firmware) -> Result<Self> {
>      fn data(&self) -> Option<&[u8]> {
>          let fw_start = usize::from_safe_cast(self.hdr.data_offset);
>          let fw_size = usize::from_safe_cast(self.hdr.data_size);
> +        let fw_end = fw_start.checked_add(fw_size)?;
>  
> -        self.fw.get(fw_start..fw_start + fw_size)
> +        self.fw.get(fw_start..fw_end)
>      }
>  }
>  

Reviewed-by: Zhi Wang <zhiw@...dia.com>