linux-kernel - Re: [PATCH v1 5/5] gpu: nova-core: use checked arithmetic in RISC-V firmware parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260126100132.7e566316.zhiw@nvidia.com>
Date: Mon, 26 Jan 2026 10:01:32 +0200
From: Zhi Wang <zhiw@...dia.com>
To: Joel Fernandes <joelagnelf@...dia.com>
CC: <linux-kernel@...r.kernel.org>, Danilo Krummrich <dakr@...nel.org>,
	Alexandre Courbot <acourbot@...dia.com>, Alice Ryhl <aliceryhl@...gle.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Paul
 Walmsley" <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, Alistair Popple
	<apopple@...dia.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Miguel Ojeda
	<ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng
	<boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, "Björn
 Roy Baron" <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross <tmgross@...ch.edu>,
	<nouveau@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<rust-for-linux@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v1 5/5] gpu: nova-core: use checked arithmetic in RISC-V
 firmware parsing

On Sat, 24 Jan 2026 18:18:30 -0500
Joel Fernandes <joelagnelf@...dia.com> wrote:

> Use checked_add() when computing offsets from firmware-provided values
> in the RISC-V firmware parsing code. These values come from the BinHdr
> structure parsed from the firmware file header.
> 
> Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
> ---
>  drivers/gpu/nova-core/firmware/riscv.rs | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/nova-core/firmware/riscv.rs
> b/drivers/gpu/nova-core/firmware/riscv.rs index
> 28dfef63657a..97030bdd9991 100644 ---
> a/drivers/gpu/nova-core/firmware/riscv.rs +++
> b/drivers/gpu/nova-core/firmware/riscv.rs @@ -47,10 +47,11 @@ impl
> RmRiscvUCodeDesc { /// Fails if the header pointed at by `bin_fw` is not
> within the bounds of the firmware image. fn new(bin_fw:
> &BinFirmware<'_>) -> Result<Self> { let offset =
> usize::from_safe_cast(bin_fw.hdr.header_offset);
> +        let end = offset.checked_add(size_of::<Self>()).ok_or(EINVAL)?;
>  
>          bin_fw
>              .fw
> -            .get(offset..offset + size_of::<Self>())
> +            .get(offset..end)
>              .and_then(Self::from_bytes_copy)
>              .ok_or(EINVAL)
>      }
> @@ -80,8 +81,9 @@ pub(crate) fn new(dev: &device::Device<device::Bound>,
> fw: &Firmware) -> Result< let ucode = {
>              let start = usize::from_safe_cast(bin_fw.hdr.data_offset);
>              let len = usize::from_safe_cast(bin_fw.hdr.data_size);
> +            let end = start.checked_add(len).ok_or(EINVAL)?;
>  
> -            DmaObject::from_data(dev, fw.data().get(start..start +
> len).ok_or(EINVAL)?)?
> +            DmaObject::from_data(dev,
> fw.data().get(start..end).ok_or(EINVAL)?)? };
>  
>          Ok(Self {

Reviewed-by: Zhi Wang <zhiw@...dia.com>