linux-kernel - Re: [PATCH v2 13/13] spi: fsi: Convert to fsi bus probe mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e852b379-eb7b-4088-ad47-471ea1d755e2@linux.ibm.com>
Date: Tue, 27 Jan 2026 09:29:52 -0600
From: Eddie James <eajames@...ux.ibm.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Ninad Palsule <ninad@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 13/13] spi: fsi: Convert to fsi bus probe mechanism


On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> The fsi bus got a dedicated probe function. Make use of that. This fixes
> a runtime warning about the driver needing to be converted to the bus
> probe method.


Acked-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> Acked-by: Mark Brown <broonie@...nel.org>
> ---
>   drivers/spi/spi-fsi.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c
> index f9c15b99dba5..07dc3d24f2c9 100644
> --- a/drivers/spi/spi-fsi.c
> +++ b/drivers/spi/spi-fsi.c
> @@ -528,13 +528,13 @@ static size_t fsi_spi_max_transfer_size(struct spi_device *spi)
>   	return SPI_FSI_MAX_RX_SIZE;
>   }
>   
> -static int fsi_spi_probe(struct device *dev)
> +static int fsi_spi_probe(struct fsi_device *fsi)
>   {
>   	int rc;
>   	struct device_node *np;
>   	int num_controllers_registered = 0;
>   	struct fsi2spi *bridge;
> -	struct fsi_device *fsi = to_fsi_dev(dev);
> +	struct device *dev = &fsi->dev;
>   
>   	rc = fsi_spi_check_mux(fsi, dev);
>   	if (rc)
> @@ -593,9 +593,9 @@ MODULE_DEVICE_TABLE(fsi, fsi_spi_ids);
>   
>   static struct fsi_driver fsi_spi_driver = {
>   	.id_table = fsi_spi_ids,
> +	.probe = fsi_spi_probe,
>   	.drv = {
>   		.name = "spi-fsi",
> -		.probe = fsi_spi_probe,
>   	},
>   };
>   module_fsi_driver(fsi_spi_driver);