linux-kernel - Re: [PATCH v2 11/13] fsi: scom: Convert to fsi bus probe mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df38c42e-3716-4945-92ec-5353e5940c18@linux.ibm.com>
Date: Tue, 27 Jan 2026 09:28:30 -0600
From: Eddie James <eajames@...ux.ibm.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Ninad Palsule <ninad@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 11/13] fsi: scom: Convert to fsi bus probe mechanism


On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> The fsi bus got a dedicated probe function. Make use of that. This fixes
> a runtime warning about the driver needing to be converted to the bus
> probe method.


Acked-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> ---
>   drivers/fsi/fsi-scom.c | 16 +++++++---------
>   1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> index 2eda44451cc1..67cd45605fe4 100644
> --- a/drivers/fsi/fsi-scom.c
> +++ b/drivers/fsi/fsi-scom.c
> @@ -527,16 +527,16 @@ static void scom_free(struct device *dev)
>   	kfree(scom);
>   }
>   
> -static int scom_probe(struct device *dev)
> +static int scom_probe(struct fsi_device *fsi_dev)
>   {
> -	struct fsi_device *fsi_dev = to_fsi_dev(dev);
> +	struct device *dev = &fsi_dev->dev;
>   	struct scom_device *scom;
>   	int rc, didx;
>   
>   	scom = kzalloc(sizeof(*scom), GFP_KERNEL);
>   	if (!scom)
>   		return -ENOMEM;
> -	dev_set_drvdata(dev, scom);
> +	fsi_set_drvdata(fsi_dev, scom);
>   	mutex_init(&scom->lock);
>   
>   	/* Grab a reference to the device (parent of our cdev), we'll drop it later */
> @@ -574,9 +574,9 @@ static int scom_probe(struct device *dev)
>   	return rc;
>   }
>   
> -static int scom_remove(struct device *dev)
> +static void scom_remove(struct fsi_device *fsi_dev)
>   {
> -	struct scom_device *scom = dev_get_drvdata(dev);
> +	struct scom_device *scom = fsi_get_drvdata(fsi_dev);
>   
>   	mutex_lock(&scom->lock);
>   	scom->dead = true;
> @@ -584,8 +584,6 @@ static int scom_remove(struct device *dev)
>   	cdev_device_del(&scom->cdev, &scom->dev);
>   	fsi_free_minor(scom->dev.devt);
>   	put_device(&scom->dev);
> -
> -	return 0;
>   }
>   
>   static const struct of_device_id scom_of_ids[] = {
> @@ -604,11 +602,11 @@ static const struct fsi_device_id scom_ids[] = {
>   
>   static struct fsi_driver scom_drv = {
>   	.id_table = scom_ids,
> +	.probe = scom_probe,
> +	.remove = scom_remove,
>   	.drv = {
>   		.name = "scom",
>   		.of_match_table = scom_of_ids,
> -		.probe = scom_probe,
> -		.remove = scom_remove,
>   	}
>   };
>