linux-kernel - Re: [PATCH v2 1/3] gpio: brcmstb: correct hwirq to bank map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD++jLnH-A=nir6YSLnsEjLmF63D+kGV=JdYDQNy6QcHhx+J8A@mail.gmail.com>
Date: Tue, 27 Jan 2026 23:15:27 +0100
From: Linus Walleij <linusw@...nel.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-kernel@...r.kernel.org, Doug Berger <opendmb@...il.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Bartosz Golaszewski <brgl@...nel.org>, Andy Shevchenko <andy.shevchenko@...il.com>, 
	Christophe Leroy <chleroy@...nel.org>, 
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, 
	"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/3] gpio: brcmstb: correct hwirq to bank map

On Tue, Jan 27, 2026 at 10:47 PM Florian Fainelli
<florian.fainelli@...adcom.com> wrote:

> From: Doug Berger <opendmb@...il.com>
>
> The brcmstb_gpio_hwirq_to_bank() function was designed to
> accommodate the downward numbering of dynamic GPIOs by
> traversing the bank list in the reverse order. However, the
> dynamic numbering has changed to increment upward which can
> produce an incorrect mapping.
>
> The function is modified to no longer assume an ordering of
> the list to accommodate either option.
>
> Fixes: 7b61212f2a07 ("gpiolib: Get rid of ARCH_NR_GPIOS")
> Signed-off-by: Doug Berger <opendmb@...il.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

This looks right.
Reviewed-by: Linus Walleij <linusw@...nel.org>

Yours,
Linus Walleij