linux-kernel - Re: [PATCH v2 2/3] gpio: brcmstb: implement irq_mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jLkCnWkuq8Sg6Jf_t1euYLN0PXtdmtQTFib6Cu--PAhPqw@mail.gmail.com>
Date: Tue, 27 Jan 2026 23:16:38 +0100
From: Linus Walleij <linusw@...nel.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: linux-kernel@...r.kernel.org, Doug Berger <opendmb@...il.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Bartosz Golaszewski <brgl@...nel.org>, Andy Shevchenko <andy.shevchenko@...il.com>, 
	Christophe Leroy <chleroy@...nel.org>, 
	"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, 
	"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/3] gpio: brcmstb: implement irq_mask_ack

On Tue, Jan 27, 2026 at 10:47 PM Florian Fainelli
<florian.fainelli@...adcom.com> wrote:

> From: Doug Berger <opendmb@...il.com>
>
> The irq_mask_ack operation is slightly more efficient than doing
> irq_mask and irq_ack separately.
>
> More importantly for this driver it bypasses the check of
> irqd_irq_masked ensuring a previously masked but still active
> interrupt gets remasked if unmasked at the hardware level. This
> allows the driver to more efficiently unmask the wake capable
> interrupts when quiescing without needing to enable the irqs
> individually to clear the irqd_irq_masked state.
>
> Signed-off-by: Doug Berger <opendmb@...il.com>
> Co-developed-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>

Reviewed-by: Linus Walleij <linusw@...nel.org>

Yours,
Linus Walleij