linux-kernel - Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMBTqh3doFnj2MVf=DP2upm-QZEjCyeu47pBchRBNFSs0eD83g@mail.gmail.com>
Date: Tue, 27 Jan 2026 01:43:57 -0600
From: Ethan Tidmore <ethantidmore06@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, Michael Straube <straube.linux@...il.com>, 
	Hans de Goede <hansg@...nel.org>, Akiyoshi Kurita <weibu@...admin.org>
Subject: Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry_priv

On Mon, Jan 26, 2026 at 08:15:43AM -0600, Dan Carpenter wrote:
> This is an unrelated white-space change.  Don't make unrelated changes.
>
> > +      struct registry_priv *r = &Adapter->registrypriv;
>
> I feel like you did this to avoid going over the 100 character limit,
> but please do that in a separate patch.  I use a script to review these
> changes and I want it to be a straight s/old/new/ change.  Plus, "r"
> is a bad name.

Hi Dan,

Thanks for the review. I actually sent a v2 patchset earlier today which
should fix the whitespace issues you mentioned here.

However, I realized v2 still uses a local struct registry_priv *r shortcut
in one of the patches which is inconsistent with the rest of the series.
I will fix that in v3.

I'll wait a bit longer to see if there are any other comments on v2 before
sending the v3 series.

Thanks,
Ethan


On Tue, Jan 27, 2026 at 12:26 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> On Mon, Jan 26, 2026 at 08:15:43AM -0600, Ethan Tidmore wrote:
> > @@ -750,7 +751,8 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
> >
> >  void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter)
> >  {
> > -     struct hal_com_data     *pHalData = GET_HAL_DATA(Adapter);
> > +     struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
>
> This is an unrelated white-space change.  Don't make unrelated changes.
>
> > +     struct registry_priv *r = &Adapter->registrypriv;
>
> I feel like you did this to avoid going over the 100 character limit,
> but please do that in a separate patch.  I use a script to review these
> changes and I want it to be a straight s/old/new/ change.  Plus, "r"
> is a bad name.
>
> regards,
> dan carpenter
>