linux-kernel - Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXhaoRMIlbRVgZui@stanley.mountain>
Date: Tue, 27 Jan 2026 09:26:41 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ethan Tidmore <ethantidmore06@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Michael Straube <straube.linux@...il.com>,
	Hans de Goede <hansg@...nel.org>,
	Akiyoshi Kurita <weibu@...admin.org>
Subject: Re: [PATCH v1] staging: rtl8723bs: rename members of struct
 registry_priv

On Mon, Jan 26, 2026 at 08:15:43AM -0600, Ethan Tidmore wrote:
> @@ -750,7 +751,8 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
>  
>  void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter)
>  {
> -	struct hal_com_data	*pHalData = GET_HAL_DATA(Adapter);
> +	struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);

This is an unrelated white-space change.  Don't make unrelated changes.

> +	struct registry_priv *r = &Adapter->registrypriv;

I feel like you did this to avoid going over the 100 character limit,
but please do that in a separate patch.  I use a script to review these
changes and I want it to be a straight s/old/new/ change.  Plus, "r"
is a bad name.

regards,
dan carpenter