linux-kernel - Re: [PATCH v10 5/7] qcom-tgu: Add support to configure next action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18099460-bd1b-433f-b700-1cdac65273e8@oss.qualcomm.com>
Date: Tue, 27 Jan 2026 11:32:21 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Songwei Chai <songwei.chai@....qualcomm.com>, andersson@...nel.org,
        alexander.shishkin@...ux.intel.com, mike.leach@...aro.org,
        suzuki.poulose@....com, james.clark@....com, krzk+dt@...nel.org,
        conor+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, coresight@...ts.linaro.org,
        devicetree@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v10 5/7] qcom-tgu: Add support to configure next action

On 1/27/26 3:43 AM, Songwei Chai wrote:
> 
> 
> On 1/13/2026 7:15 PM, Konrad Dybcio wrote:
>> On 1/9/26 3:11 AM, Songwei Chai wrote:
>>> Add "select" node for each step to determine if another step is taken,
>>> trigger(s) are generated, counters/timers incremented/decremented, etc.
>>>
>>> Signed-off-by: Songwei Chai <songwei.chai@....qualcomm.com>
>>> ---

[...]

>>> +    select = devm_kzalloc(dev, select_size, GFP_KERNEL);
>>> +
>>> +    if (!select)
>>
>> stray \n
> Will improve this based on the comments above.
>>
>>> +        return -ENOMEM;
>>> +
>>> +    drvdata->value_table->condition_select = select;
>>
>> I don't see a need for an intemediate variable here
> 
> This was done intentionally, following the earlier suggestion in v9 to
> introduce named intermediate variables for better readability when dealing with allocations.
> 
> I’m happy to inline the allocation if you prefer the simpler form here.

I don't mind that much

Konrad