linux-kernel - Re: [PATCH v2 08/13] arm64: mm: Simplify __flush_tlb_range_limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260127121527.0000227e@huawei.com>
Date: Tue, 27 Jan 2026 12:15:27 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Ryan Roberts <ryan.roberts@....com>
CC: Will Deacon <will@...nel.org>, Ard Biesheuvel <ardb@...nel.org>, Catalin
 Marinas <catalin.marinas@....com>, Mark Rutland <mark.rutland@....com>, Linus
 Torvalds <torvalds@...ux-foundation.org>, Oliver Upton
	<oliver.upton@...ux.dev>, Marc Zyngier <maz@...nel.org>, "Dev Jain"
	<dev.jain@....com>, Linu Cherian <Linu.Cherian@....com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 08/13] arm64: mm: Simplify
 __flush_tlb_range_limit_excess()

On Mon, 19 Jan 2026 17:21:55 +0000
Ryan Roberts <ryan.roberts@....com> wrote:

> From: Will Deacon <will@...nel.org>
> 
> __flush_tlb_range_limit_excess() is unnecessarily complicated:
> 
>   - It takes a 'start', 'end' and 'pages' argument, whereas it only
>     needs 'pages' (which the caller has computed from the other two
>     arguments!).
> 
>   - It erroneously compares 'pages' with MAX_TLBI_RANGE_PAGES when
>     the system doesn't support range-based invalidation but the range to
>     be invalidated would result in fewer than MAX_DVM_OPS invalidations.
> 
> Simplify the function so that it no longer takes the 'start' and 'end'
> arguments and only considers the MAX_TLBI_RANGE_PAGES threshold on
> systems that implement range-based invalidation.
> 
> Signed-off-by: Will Deacon <will@...nel.org>
> Signed-off-by: Ryan Roberts <ryan.roberts@....com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>