[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <64961e27-e316-47d1-8ab4-c4868754adb6@oss.qualcomm.com>
Date: Tue, 27 Jan 2026 14:21:47 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Praveen Talari <praveen.talari@....qualcomm.com>,
Mark Brown <broonie@...nel.org>, linux-arm-msm@...r.kernel.org,
linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
bjorn.andersson@....qualcomm.com, dmitry.baryshkov@....qualcomm.com
Cc: prasad.sodagudi@....qualcomm.com, mukesh.savaliya@....qualcomm.com,
quic_vtanuku@...cinc.com, aniket.randive@....qualcomm.com,
chandana.chiluveru@....qualcomm.com, jyothi.seerapu@....qualcomm.com
Subject: Re: [PATCH v1 3/3] spi: geni-qcom: Add target abort support
On 1/22/26 4:10 PM, Praveen Talari wrote:
> SPI target mode currently lacks a mechanism to gracefully abort ongoing
> transfers when the client or core needs to cancel active transactions.
>
> Implement spi_geni_target_abort() to handle aborting SPI target
> operations when the client and core want to cancel ongoing transfers.
> This provides a mechanism for graceful termination of active SPI
> transactions in target mode.
>
> Signed-off-by: Praveen Talari <praveen.talari@....qualcomm.com>
> ---
> drivers/spi/spi-geni-qcom.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
> index e5320e2fb834..231fd31de048 100644
> --- a/drivers/spi/spi-geni-qcom.c
> +++ b/drivers/spi/spi-geni-qcom.c
> @@ -1009,6 +1009,17 @@ static irqreturn_t geni_spi_isr(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> +static int spi_geni_target_abort(struct spi_controller *spi)
> +{
> + if (!spi->cur_msg)
> + return 0;
> +
> + handle_se_timeout(spi, spi->cur_msg);
I can't help but notice this function never even dereferences this
argument
Konrad
Powered by blists - more mailing lists