| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202601282153.4kuaeoS5-lkp@intel.com>
Date: Wed, 28 Jan 2026 21:21:15 +0800
From: kernel test robot <lkp@...el.com>
To: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>,
Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>
Cc: oe-kbuild-all@...ts.linux.dev,
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@....com>,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 04/11] amdgpu/vce: use amdgpu_gtt_mgr_alloc_entries
Hi Pierre-Eric,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20260123]
[cannot apply to drm-misc/drm-misc-next v6.19-rc7 v6.19-rc6 v6.19-rc5 linus/master v6.19-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pierre-Eric-Pelloux-Prayer/drm-amdgpu-remove-gart_window_lock-usage-from-gmc-v12_1/20260126-214013
base: next-20260123
patch link: https://lore.kernel.org/r/20260126133518.2486-5-pierre-eric.pelloux-prayer%40amd.com
patch subject: [PATCH v6 04/11] amdgpu/vce: use amdgpu_gtt_mgr_alloc_entries
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20260128/202601282153.4kuaeoS5-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260128/202601282153.4kuaeoS5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601282153.4kuaeoS5-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/vce_v1_0.c: In function 'vce_v1_0_ensure_vcpu_bo_32bit_addr':
>> drivers/gpu/drm/amd/amdgpu/vce_v1_0.c:533:13: warning: unused variable 'gpu_addr' [-Wunused-variable]
533 | u64 gpu_addr = amdgpu_bo_gpu_offset(adev->vce.vcpu_bo);
| ^~~~~~~~
vim +/gpu_addr +533 drivers/gpu/drm/amd/amdgpu/vce_v1_0.c
d4a640d4b9f34a Timur Kristóf 2025-11-07 516
221cadb9c6bc2e Timur Kristóf 2025-11-07 517 /**
221cadb9c6bc2e Timur Kristóf 2025-11-07 518 * vce_v1_0_ensure_vcpu_bo_32bit_addr() - ensure the VCPU BO has a 32-bit address
221cadb9c6bc2e Timur Kristóf 2025-11-07 519 *
221cadb9c6bc2e Timur Kristóf 2025-11-07 520 * @adev: amdgpu_device pointer
221cadb9c6bc2e Timur Kristóf 2025-11-07 521 *
221cadb9c6bc2e Timur Kristóf 2025-11-07 522 * Due to various hardware limitations, the VCE1 requires
221cadb9c6bc2e Timur Kristóf 2025-11-07 523 * the VCPU BO to be in the low 32 bit address range.
221cadb9c6bc2e Timur Kristóf 2025-11-07 524 * Ensure that the VCPU BO has a 32-bit GPU address,
221cadb9c6bc2e Timur Kristóf 2025-11-07 525 * or return an error code when that isn't possible.
221cadb9c6bc2e Timur Kristóf 2025-11-07 526 *
221cadb9c6bc2e Timur Kristóf 2025-11-07 527 * To accomodate that, we put GART to the LOW address range
221cadb9c6bc2e Timur Kristóf 2025-11-07 528 * and reserve some GART pages where we map the VCPU BO,
221cadb9c6bc2e Timur Kristóf 2025-11-07 529 * so that it gets a 32-bit address.
221cadb9c6bc2e Timur Kristóf 2025-11-07 530 */
221cadb9c6bc2e Timur Kristóf 2025-11-07 531 static int vce_v1_0_ensure_vcpu_bo_32bit_addr(struct amdgpu_device *adev)
221cadb9c6bc2e Timur Kristóf 2025-11-07 532 {
221cadb9c6bc2e Timur Kristóf 2025-11-07 @533 u64 gpu_addr = amdgpu_bo_gpu_offset(adev->vce.vcpu_bo);
221cadb9c6bc2e Timur Kristóf 2025-11-07 534 u64 bo_size = amdgpu_bo_size(adev->vce.vcpu_bo);
221cadb9c6bc2e Timur Kristóf 2025-11-07 535 u64 max_vcpu_bo_addr = 0xffffffff - bo_size;
221cadb9c6bc2e Timur Kristóf 2025-11-07 536 u64 num_pages = ALIGN(bo_size, AMDGPU_GPU_PAGE_SIZE) / AMDGPU_GPU_PAGE_SIZE;
221cadb9c6bc2e Timur Kristóf 2025-11-07 537 u64 pa = amdgpu_gmc_vram_pa(adev, adev->vce.vcpu_bo);
221cadb9c6bc2e Timur Kristóf 2025-11-07 538 u64 flags = AMDGPU_PTE_READABLE | AMDGPU_PTE_WRITEABLE | AMDGPU_PTE_VALID;
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 539 u64 vce_gart_start;
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 540 int r;
221cadb9c6bc2e Timur Kristóf 2025-11-07 541
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 542 r = amdgpu_gtt_mgr_alloc_entries(&adev->mman.gtt_mgr,
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 543 &adev->vce.node, num_pages,
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 544 DRM_MM_INSERT_LOW);
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 545 if (r)
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 546 return r;
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 547
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 548 vce_gart_start = adev->vce.node.start * AMDGPU_GPU_PAGE_SIZE;
221cadb9c6bc2e Timur Kristóf 2025-11-07 549
221cadb9c6bc2e Timur Kristóf 2025-11-07 550 /* Check if we can map the VCPU BO in GART to a 32-bit address. */
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 551 if (adev->gmc.gart_start + vce_gart_start > max_vcpu_bo_addr)
221cadb9c6bc2e Timur Kristóf 2025-11-07 552 return -EINVAL;
221cadb9c6bc2e Timur Kristóf 2025-11-07 553
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 554 amdgpu_gart_map_vram_range(adev, pa, adev->vce.node.start,
221cadb9c6bc2e Timur Kristóf 2025-11-07 555 num_pages, flags, adev->gart.ptr);
6e8defc22cdff6 Pierre-Eric Pelloux-Prayer 2026-01-26 556 adev->vce.gpu_addr = adev->gmc.gart_start + vce_gart_start;
221cadb9c6bc2e Timur Kristóf 2025-11-07 557 if (adev->vce.gpu_addr > max_vcpu_bo_addr)
221cadb9c6bc2e Timur Kristóf 2025-11-07 558 return -EINVAL;
221cadb9c6bc2e Timur Kristóf 2025-11-07 559
221cadb9c6bc2e Timur Kristóf 2025-11-07 560 return 0;
221cadb9c6bc2e Timur Kristóf 2025-11-07 561 }
221cadb9c6bc2e Timur Kristóf 2025-11-07 562
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists