linux-kernel - Re: [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXoNztBM_kVOIAHV@stanley.mountain>
Date: Wed, 28 Jan 2026 16:23:26 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ethan Tidmore <ethantidmore06@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Michael Straube <straube.linux@...il.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic

On Tue, Jan 27, 2026 at 06:40:04PM -0600, Ethan Tidmore wrote:
> This series performs a driver-wide audit and cleanup of dead diagnostic 
> code within the rtl8723bs staging driver.
> 
> The vendor-originated code included a variety of diagnostic counters 
> housed within 'struct debug_priv'. These counters were updated 
> throughout the driver's hot paths—including MLME, receive, power 
> control, and SDIO allocation—but were never read, exposed via 
> debugfs, or utilized for any internal logic.
> 
> This series removes the write-only counters, the skeletal functions 
> used to update them, and cleans up the resulting unused pointers 
> and logic blocks.
> 
> Changes in v2:
> - Expanded the series to include the removal of RX FIFO overflow 
>   logic in hal_com.c.
> 

Please don't send multiple versions of a patch on the same day.

Anyway, kbuild bot complained so at least I don't have to review this
now.

regards,
dan carpenter