linux-kernel - Re: [PATCH v2 4/4] staging: rtl8723bs: fix line length check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DG0CQ4MCS7P8.2FW5L1RVCYB6L@gmail.com>
Date: Wed, 28 Jan 2026 21:09:45 +0500
From: "Mahad Ibrahim" <mahad.ibrahim.dev@...il.com>
To: "Greg KH" <gregkh@...uxfoundation.org>
Cc: <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] staging: rtl8723bs: fix line length check

On Tue Jan 27, 2026 at 7:40 PM PKT, Greg KH wrote:
>> -		if ((cond2 & bitMask) == (driver2 & bitMask)) /*  BoardType of each RF path is matched */
>> +		/*  BoardType of each RF path is matched */
>
> Why the extra space after /* and before BoardType?
>
> thanks,
>
> greg k-h

Thank you for the review.

I included it to match the existing comment style prevalent in this
specific file. Not adding it would have caused inconsistency.

However I realize this violates the kernel coding standards.

I will send a v3 series that addresses this issue, as well as fix the
line comment style in that file as a separate logical change.

thanks,

Mahad Ibrahim