linux-kernel - Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXpCwkEBZMMmDAsR@kernel.org>
Date: Wed, 28 Jan 2026 19:09:22 +0200
From: Mike Rapoport <rppt@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...nel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>,
	"Rob Herring (Arm)" <robh@...nel.org>,
	Oreoluwa Babatunde <oreoluwa.babatunde@....qualcomm.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem()

On Wed, Jan 28, 2026 at 04:28:35PM +0000, Mark Brown wrote:
> The stub for cma_skip_dt_default_reserved_mem() is not inlined so
> triggers build warnings:
> 
> In file included from /tmp/next/build/fs/proc/meminfo.c:18:
> /tmp/next/build/include/linux/cma.h:68:13: warning: 'cma_skip_dt_default_reserved_mem' defined but not used [-Wunused-function]
>    68 | static bool cma_skip_dt_default_reserved_mem(void)
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> which are fatal with -Werror.
> 
> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework detect "cma=" kernel param")
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

> ---
>  include/linux/cma.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/cma.h b/include/linux/cma.h
> index 0bf408360641..d0793eaaadaa 100644
> --- a/include/linux/cma.h
> +++ b/include/linux/cma.h
> @@ -65,7 +65,7 @@ extern void cma_reserve_pages_on_error(struct cma *cma);
>  #ifdef CONFIG_DMA_CMA
>  extern bool cma_skip_dt_default_reserved_mem(void);
>  #else
> -static bool cma_skip_dt_default_reserved_mem(void)
> +static inline bool cma_skip_dt_default_reserved_mem(void)
>  {
>  	return false;
>  }
> 
> ---
> base-commit: d0d97f0b2b2b4633022dfaef4ac08af0b7917efe
> change-id: 20260128-cma-fix-stubs-26b13ce1471d
> 
> Best regards,
> --  
> Mark Brown <broonie@...nel.org>
> 

-- 
Sincerely yours,
Mike.