linux-kernel - Re: [PATCH] mailbox: Clean up the usage of mailbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXm/v5KWJf3k7V6a@shlinux89>
Date: Wed, 28 Jan 2026 15:50:23 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Sudeep Holla <sudeep.holla@...nel.org>
Cc: Peng Fan <peng.fan@....com>, Jassi Brar <jassisinghbrar@...il.com>,
	Beleswar Padhi <b-padhi@...com>, Andrew Davis <afd@...com>,
	Yuntao Dai <d1581209858@...e.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"mailbox@...ts.linux.dev" <mailbox@...ts.linux.dev>
Subject: Re: [PATCH] mailbox: Clean up the usage of mailbox_client.h

On Tue, Jan 27, 2026 at 04:00:39PM +0000, Sudeep Holla wrote:
>On Tue, Jan 27, 2026 at 02:47:33PM +0000, Peng Fan wrote:
[...]
>> > > >  #include <linux/mailbox_controller.h> -#include
>> > > > <linux/mailbox_client.h>  #include <linux/io-64-nonatomic-lo-hi.h>
>> > > > #include <acpi/pcc.h>
>> > > >
>> > >
>> > > There is a call to mbox_bind_client() in pcc.c that is declared in
>> > > linux/mailbox_client.h
>> > 
>> > Thanks for raising this.
>> 
>> Check again.
>> 
>> include/acpi/pcc.h includes mailbox_client.h
>> 
>
>I see, I missed that. I’m fine with removing it, but the commit message
>doesn’t really apply here since it’s getting included anyway. I don’t see
>much point in removing it, but I’m fine either way.

I will remove the change to pcc.c in V2, since this driver uses
mbox_bind_client().

Thanks,
Peng

>-- 
>Regards,
>Sudeep
>