linux-kernel - Re: [PATCH net-next V6 07/14] devlink: Add parent dev to devlink API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXnU-klD1_rHY0D0@horms.kernel.org>
Date: Wed, 28 Jan 2026 09:20:58 +0000
From: Simon Horman <horms@...nel.org>
To: Cosmin Ratiu <cratiu@...dia.com>
Cc: Tariq Toukan <tariqt@...dia.com>, "corbet@....net" <corbet@....net>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"donald.hunter@...il.com" <donald.hunter@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"leon@...nel.org" <leon@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"jiri@...nulli.us" <jiri@...nulli.us>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	Jiri Pirko <jiri@...dia.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Carolina Jubran <cjubran@...dia.com>,
	Mark Bloch <mbloch@...dia.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"rdunlap@...radead.org" <rdunlap@...radead.org>,
	Saeed Mahameed <saeedm@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Gal Pressman <gal@...dia.com>, Moshe Shemesh <moshe@...dia.com>,
	"krzk@...nel.org" <krzk@...nel.org>
Subject: Re: [PATCH net-next V6 07/14] devlink: Add parent dev to devlink API

On Tue, Jan 27, 2026 at 02:25:51PM +0000, Cosmin Ratiu wrote:
> On Tue, 2026-01-27 at 13:49 +0000, Simon Horman wrote:
> > On Sun, Jan 25, 2026 at 01:31:56PM +0200, Tariq Toukan wrote:
> > > From: Cosmin Ratiu <cratiu@...dia.com>

...

Hi Cosmin,

> Hi Simon,
> 
> We had this conversation during v4, I replied then [1].

Sorry, I had forgotten about that.

> But thinking about it a bit more, I think it's indeed slightly cleaner
> to move the policy and the new pre/post doit handlers to the next
> patch, where they are actually used. The only bit is that the policy is
> used from devlink_get_parent_from_attrs_lock from this function, but it
> appears safe to use NULL there until next patch (the underlying parse
> functions tolerate NULL policies).
> 
> So I'll do that in the next submission.

Thanks, that makes sense.
And I'll try to remember this conversation when looking at the next version :)

> 
> [1]
> https://lore.kernel.org/netdev/3ec956ea1d0a1c6e56865b2ded6d83ed773ccd4d.camel@nvidia.com/