linux-kernel - Re: [PATCH] iio: addac: ad74115: Add missing check for device_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXnZsCD01-LUVNGx@smile.fi.intel.com>
Date: Wed, 28 Jan 2026 11:41:04 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Chen Ni <nichen@...as.ac.cn>, lars@...afoo.de,
	Michael.Hennerich@...log.com, cosmin.tanislav@...log.com,
	jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: addac: ad74115: Add missing check for
 device_property_read_u32_array

On Wed, Jan 28, 2026 at 09:34:18AM +0000, Nuno Sá wrote:
> On Wed, 2026-01-28 at 12:30 +0800, Chen Ni wrote:
> > Add check for the return value of device_property_read_u32_array() and
> > return the error if it fails in order to catch the error.

...

> > -	device_property_read_u32_array(dev, prop_name, vals, 2);
> > +	ret = device_property_read_u32_array(dev, prop_name, vals, 2);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "Failed to read %s prop\n",
> > +				     prop_name);
> 
> Thanks for the patch but this is intentional. Not a mandatory property.

No need for further actions. NAK to the change. We don't want to have a monster
with the custom error checking.

P.S. The author also must answer if this was found by some static analyser
tool. If so, the stream from this "tool" should be blocked for now.

-- 
With Best Regards,
Andy Shevchenko