linux-kernel - Re: [PATCH] gpio: spacemit-k1: Use PDR for pin direction, not SDR/CDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176959330536.12707.18374071693115296433.b4-ty@oss.qualcomm.com>
Date: Wed, 28 Jan 2026 10:41:49 +0100
From: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
To: Linus Walleij <linusw@...nel.org>, Bartosz Golaszewski <brgl@...nel.org>,
        Yixun Lan <dlan@...too.org>, Alex Elder <elder@...cstar.com>,
        Vivian Wang <wangruikang@...as.ac.cn>
Cc: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
        linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: spacemit-k1: Use PDR for pin direction, not SDR/CDR


On Tue, 27 Jan 2026 10:58:49 +0800, Vivian Wang wrote:
> On the SpacemiT GPIO controller, the direction control register PDR is
> readable and writable [1]. Therefore, implement direction control by
> using PDR as dirout, and don't mark it as unreadable.
> 
> The original implementation, using SDR as dirout and CDR as dirin, is
> not actually a supported configuration by gpio-mmio. The hardware
> supports changing the direction of some pins atomically by writing a
> value with the corresponding bits set to SDR (set as output) or to CDR
> (set as input). However, gpio-mmio does not actually handle this.
> 
> [...]

Applied, thanks!

[1/1] gpio: spacemit-k1: Use PDR for pin direction, not SDR/CDR
      https://git.kernel.org/brgl/c/aa7e37fd770bafaaf856ab77735296955b93e377

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>