linux-kernel - Re: [PATCH] hwmon: (tmp513) Add missing check for device_property_read_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ade6258-8df6-483b-9f55-3d38e9a50cb3@roeck-us.net>
Date: Thu, 29 Jan 2026 06:20:57 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Chen Ni <nichen@...as.ac.cn>
Cc: etremblay@...tech-controls.com, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (tmp513) Add missing check for
 device_property_read_u32_array

On Wed, Jan 28, 2026 at 03:30:21PM +0800, Chen Ni wrote:
> Add check for the return value of device_property_read_u32_array() and
> return the error if it fails in order to catch the error.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/hwmon/tmp513.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/tmp513.c b/drivers/hwmon/tmp513.c
> index 5acbfd7d088d..f201d0a9ba14 100644
> --- a/drivers/hwmon/tmp513.c
> +++ b/drivers/hwmon/tmp513.c
> @@ -676,8 +676,10 @@ static int tmp51x_read_properties(struct device *dev, struct tmp51x_data *data)
>  	if (ret < 0)
>  		return ret;
>  
> -	device_property_read_u32_array(dev, "ti,nfactor", data->nfactor,
> -				       data->max_channels - 1);
> +	ret = device_property_read_u32_array(dev, "ti,nfactor", data->nfactor,
> +					     data->max_channels - 1);
> +	if (ret)
> +		return ret;

NACK. The default is 0, and the property is optional.

Guenter

>  
>  	// Check if shunt value is compatible with pga-gain
>  	if (data->shunt_uohms > data->pga_gain * 40 * MICRO) {
> -- 
> 2.25.1
> 
>