linux-kernel - Re: [PATCH v3 0/5] gpu: nova-core: gsp: fix command queue ring buffer bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DG1522O8EVWU.1J7Y5529FM1RS@garyguo.net>
Date: Thu, 29 Jan 2026 14:21:53 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Eliot Courtney" <ecourtney@...dia.com>, "Danilo Krummrich"
 <dakr@...nel.org>, "Alexandre Courbot" <acourbot@...dia.com>, "Alice Ryhl"
 <aliceryhl@...gle.com>, "David Airlie" <airlied@...il.com>, "Simona Vetter"
 <simona@...ll.ch>, "Alistair Popple" <apopple@...dia.com>
Cc: <nouveau@...ts.freedesktop.org>, <rust-for-linux@...r.kernel.org>,
 <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/5] gpu: nova-core: gsp: fix command queue ring
 buffer bugs

On Thu Jan 29, 2026 at 7:44 AM GMT, Eliot Courtney wrote:
> This series fixes a few bugs in the GSP command queue ring buffer
> implementation in nova-core and also clarifies some of the comments.
>
> The ring buffer uses read and write pointers (rx/tx) to track which areas
> are available for the CPU vs the GSP to read/write into.
>
> In the ring buffers there were some indexing issues which could end up
> causing panics, so I fixed those and added more rigorous proofs of
> correctness in the panic comments.
>
> Signed-off-by: Eliot Courtney <ecourtney@...dia.com>

For the whole series:

Reviewed-by: Gary Guo <gary@...yguo.net>

Best,
Gary

> ---
> Changes in v3:
> - Use `&mut []` instead of `&mut xyz[0..0]` for empty slices.
> - Simplify driver_read_area by removing unnecessary split_at.
> - Use range notation for comments (e.g., `is within 0..MSGQ_NUM_PAGES`).
> - Fix up branch order to mirror existing code.
> - Link to v2: https://lore.kernel.org/r/20260123-nova-core-cmdq1-v2-0-e797ec1b714c@nvidia.com
>
> Changes in v2:
> - Modified PANIC comments to match existing style.
> - Link to v1: https://lore.kernel.org/r/20260122-nova-core-cmdq1-v1-0-7f8fe4683f11@nvidia.com
>
> ---
> Eliot Courtney (5):
>       gpu: nova-core: gsp: fix incorrect advancing of write pointer
>       gpu: nova-core: gsp: clarify comments about invariants and pointer roles
>       gpu: nova-core: gsp: use empty slices instead of [0..0] ranges
>       gpu: nova-core: gsp: fix improper handling of empty slot in cmdq
>       gpu: nova-core: gsp: fix improper indexing in driver_read_area
>
>  drivers/gpu/nova-core/gsp/cmdq.rs | 71 +++++++++++++++++++++++----------------
>  1 file changed, 42 insertions(+), 29 deletions(-)
> ---
> base-commit: 58d26d42818c0f8c9b334cc7cf318b43046e675f
> change-id: 20260121-nova-core-cmdq1-6aaa369824c4
>
> Best regards,